Mark the font size support flag as stable #25695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Block API
youknowriad
requested review from
ajitbohra,
ellatrix,
Soean,
spacedmonkey,
talldan and
TimothyBJacobs
as code owners
|
Size Change: -16 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
ItsJonQ
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
🚀 from me! Tested locally and its working as expected 😍 .
Amazing @youknowriad !
|
Not related to this PR... but I noticed the font-size select may have styling issues? 😅
|
aristath
approved these changes
Sep 30, 2020
|
I'm not against merging this to keep moving. But as Q notes, the font size picker really needs love. It's entirely broken in the theme I'm working on:
Those aren't even that big font sizes. It seems we should either elide the text, or revisit the idea of showing the rendered size entirely. A 96px font size sounds crazy, but it's quite easy to get up there and beyond inside a decorative Cover block. |
|
|
These are good points but it's completely unrelated to this PR. That component is already rendering like that on master with or without this support flag. |
youknowriad
force-pushed
the
update/font-size-support-hook
branch
from
bc51dcc
to
d911b31
Compare
tellthemachines
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #25694
With this PR, third-party block authors using the "light block wrapper" will be able to add font-size support with a single line of code to their custom blocks.