Remove appender from unselected Buttons and Social Icons block. #25518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Bug
ZebulanStanphill
requested review from
ellatrix and
youknowriad
as code owners
Comment on lines
+51
to
+52
| ( ! selectedBlockClientId || | ||
| isAnotherDefaultAppenderAlreadyDisplayed ) |
There was a problem hiding this comment.
In case you're wondering, the alteration here prevents non-root-level appenders from rendering when no block is selected.
|
Size Change: +4 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
the
[Block] Social
ZebulanStanphill
changed the title
6 tasks
ellatrix
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21805. Turns out this was a generic issue, and fixing it fixes similar issues with other blocks, e.g. the Social Icons block. It also helps to unblock #23222, which in turn will help unblock #23168. In other words, please review this PR. 😛
How has this been tested?
I've made sure that the Buttons block appender now only appears when the Buttons block or one of its children is selected. The appender is not visible when any other blocks (or no blocks) are selected, as expected.
Screenshots
Note that no blocks are selected in any of these pictures. Note that in the old (broken) behavior, the appender is invisible (but still taking up space) for the Buttons block; I'm still not sure why it was invisible for the Buttons block.
Before
After
Checklist: