Add full parameters for emulateNetworkConditions #24144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
ajitbohra,
chrisvanpatten,
nerrad,
ntwb and
talldan
as code owners
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
tellthemachines
force-pushed
the
fix/e2e-network-emulation
branch
from
02e53bb
to
c6b671d
Compare
tellthemachines
added
[Type] Bug
noisysocks
approved these changes
Jul 30, 2020
| // Upload speed (bytes/s) | ||
| uploadThroughput: ( ( 750 * 1024 ) / 8 ) * 0.9, | ||
| // Latency (ms) | ||
| latency: 150 * 3.75, |
There was a problem hiding this comment.
These numbers (particularly 150 and 0.9) are a bit "magic" so I think let's link to https://github.com/ChromeDevTools/devtools-frontend/blob/80c102878fd97a7a696572054007d40560dcdd21/front_end/sdk/NetworkManager.js#L252-L274 in an inline comment.
tellthemachines
force-pushed
the
fix/e2e-network-emulation
branch
from
c6b671d
to
0459a5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23982 by replacing
DOWNLOAD_THROUGHPUTwithSLOW_NETWORK, that passes a fixed set of parameters toNetwork.emulateNetworkConditionsso it can work correctly. The exact values are taken from ChromeDevTools Fast 3G emulation settings.Also adds an
OFFLINEoption, that allows simulation of offline conditions.How has this been tested?
Tested by running the e2e tests and verifying that they run slower when
SLOW_NETWORK=trueis added beforenpm run test-e2e; also that multiplenet::ERR_INTERNET_DISCONNECTEDappear whenOFFLINE=trueis added.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: