Make the line height and custom units theme support flags consistent #23964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
Backport to WP 6.7 Beta/RC
youknowriad
requested review from
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
youknowriad
commented
Jul 15, 2020
| @@ -655,7 +655,7 @@ function gutenberg_extend_settings_block_patterns( $settings ) { | |||
| * @return array Filtered editor settings. | |||
| */ | |||
| function gutenberg_extend_settings_custom_line_height( $settings ) { | |||
| $settings['__experimentalEnableCustomLineHeight'] = get_theme_support( 'experimental-line-height' ); | |||
| $settings['enableCustomLineHeight'] = get_theme_support( 'custom-line-height' ); | |||
There was a problem hiding this comment.
I was hesitant whether to call this "line-height" or "custom-line-height" I went with custom for consistency with other theme support flags (units, spacing).
youknowriad
added
the
Needs Dev Note
|
This will require some changes to Core editor settings file. This was missed in previous betas. |
|
Size Change: +8.58 kB (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/consistent-opt-in-support-lineheight-custom-units
branch
from
85ecfc7
to
fd9879f
Compare
ItsJonQ
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
@youknowriad Thank you for following up with this PR! It looks good to me. custom-line-height makes sense to me!
youknowriad
deleted the
update/consistent-opt-in-support-lineheight-custom-units
branch
6 tasks
ellatrix
pushed a commit
that referenced
this pull request
Jul 20, 2020
youknowriad
removed
Backport to WP 6.7 Beta/RC
|
I think we should make custom units opt-out not opt-in. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #23904
This makes both flags consistent: opt-in and stable as mentioned on the WP 5.5 release post https://wordpress.org/news/2020/07/wordpress-5-5-beta-1/