Try: Reduced specificity base block margins. #22051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Code Quality
jasmussen
requested review from
ajitbohra,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
|
Size Change: -16 B (0%) Total Size: 825 kB
ℹ️ View Unchanged
|
ellatrix
approved these changes
May 3, 2020
|
Yes this rule need eventually be removed entirely. A lot of core blocks rely on and assume the presence of these margins. These blocks need to be able to work without them, or we need something else to take it's place. For example anything wrapped in a figure element could probably work without them, but anything just in a div either need some margins in style.scss or theme.scss. We also need to handle the vanilla styles; what you see in the editor when your theme doesn't style it. There needs to be some margin rhythm for that. Some blocks compensate for these margins, i.e. with negative margins. Those need to me refactored. And finally, all the above needs good testing with themes and plugins, so that the breakage is acceptable. We should totally do it, but there are a few steps to get there. I wonder if a global style block margin has value? Probably not but something to think about. Thanks for the review! |
This is a simple change that benefits themes. It reduces the specificity of the rule that provides a baseline block margin. The baseline block margin is the margin above and below every block, which these blocks are born with. In master, this rule is so specific that it overrides many editor styles that should work.
jasmussen
force-pushed
the
try/reduced-specificity-block-margins
branch
from
0f3a384
to
99ec348
Compare
|
Tested this again with a couple of themes, and block nesting, and there appears to be no side effects that I an discern. Rebased and marging when the checks pass. |
|
I created #22208 as a place to start the discussion of removing the baseline margin entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change that benefits themes. It reduces the specificity of the rule that provides a baseline block margin.
The baseline block margin is the margin above and below every block, which these blocks are born with.
In master, this rule is so specific that it overrides many editor styles that should work.
Before:
After:
Note how this theme provides 1em margins through the following editor style:
This overrides the baseline rule, as it should:
It also seems to work fine for TwentyTwenty and TwentyNineteen: