Embed Block: Fix rendering the embed blocks (wideImage JS error) #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vided as a prop anymore
youknowriad
added
the
[Type] Bug
Codecov Report
@@ Coverage Diff @@
## master #2178 +/- ##
=======================================
Coverage 22.15% 22.15%
=======================================
Files 138 138
Lines 4283 4283
Branches 723 723
=======================================
Hits 949 949
Misses 2814 2814
Partials 520 520
Continue to review full report at Codecov.
|
aduth
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with #2119 the editor settings are not provided as a prop to the blocks anymore. I somehow missed refactoring the embed blocks in this PR.