Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a different design for blocks in inserter #2153

Closed
wants to merge 4 commits into from

Conversation

jasmussen
Copy link
Contributor

This makes the blocks bigger touch targets. It should also let long lines wrap more gracefully.

Screenshot:

screen shot 2017-08-02 at 13 31 12

@jasmussen jasmussen self-assigned this Aug 2, 2017
@jasmussen jasmussen requested review from mtias and afercia August 2, 2017 11:38
@mtias
Copy link
Member

mtias commented Aug 2, 2017

I like this version, as it handles i18n better. Also has room for bigger icons if we wanted.

@mtias
Copy link
Member

mtias commented Aug 2, 2017

Not so sure about the centered category names:

image

@afercia
Copy link
Contributor

afercia commented Aug 2, 2017

Was going to say the same thing... I tend to miss the centered group titles. Left aligned, they drive my attention instead. Before and after:

screen shot 2017-08-02 at 16 05 27

Embeds tab before and after:

screen shot 2017-08-02 at 16 21 35

@mtias
Copy link
Member

mtias commented Aug 2, 2017

Trying sticky headings:

inserter-sticky-headings

I think it could still be left aligned in this case.

@moorscode
Copy link
Contributor

moorscode commented Aug 2, 2017

On the embed tabs

When the same icon is used for different items, but is used as the main identifier it is a lot harder to find what I need. This is true for a couple of video icons at least.

There is a slight preference for the more compact version, because the spacing between the icon and the text is reduced, which makes it much more clear when an element starts and ends.
Making it much more scannable.

I find the different weight of the icons being visually less appealing when comparing the '-' separator to the '[ ]' button examples in the screenshot.

My preference is for the compact version, as the icon and label are of the same order.

@afercia
Copy link
Contributor

afercia commented Aug 2, 2017

@mtias sticky is not supported in IE11 and Edge: http://caniuse.com/#search=sticky

@jasmussen
Copy link
Contributor Author

I dig the sticky. I also think it's okay that it's not functioning in Edge/IE11, as the fallback, if I remember correctly, is "no change". So it's sort of a progressive enhancement.

@moorscode
Copy link
Contributor

The sticky looks very sexy to me.

It is reducing the available screen-estate, but the added grouping context being visible all the time seems to make up for that.

@mtias
Copy link
Member

mtias commented Aug 2, 2017

@moorscode yes, I think we could make the whole thing a bit larger now since each individual block item takes more space.

@hedgefield
Copy link

+1 for sticky headers! Nice. Mostly the borders of the headers do a good job separating the categories. Without them it was very chaotic.

@afercia
Copy link
Contributor

afercia commented Aug 2, 2017

I'm sorry but this is what I get with some basic keyboard testing. Just tabbing forwards and backwards through the items. On the left: two titles. On the right: items partially hidden by the title (common issue with fixed elements when tabbing backwards).

screen shot 2017-08-02 at 16 42 50

I'm not sure this can be solved without hacks that would make the whole thing too fragile. I feel like we're really overcomplicating the inserter without solving the real issue: too many things in a too small space.

@ellatrix
Copy link
Member

ellatrix commented Aug 2, 2017

Personally I find centring the icons and text more chaotic looking, and harder to scan through.

@jdevalk
Copy link
Contributor

jdevalk commented Aug 3, 2017

Agree with@iseulde. Don’t see why this is an improvement to be honest...

@mtias
Copy link
Member

mtias commented Aug 3, 2017

Don’t see why this is an improvement to be honest...

Longer text in other languages breaks badly and doesn't look very nice.

@jasmussen
Copy link
Contributor Author

@moorscode

When the same icon is used for different items, but is used as the main identifier it is a lot harder to find what I need. This is true for a couple of video icons at least.

See also WordPress/dashicons#203

@jasmussen
Copy link
Contributor Author

I think we should revisit this branch. I understand the reluctance, but it brings some much needed touch target improvements to mobile. And with the slash command possibly arriving soon (see #2284), it seems sensible to have a larger more expansive look for the top inserter. It would also fix #1497.

@jasmussen
Copy link
Contributor Author

Closing this in favor of #3080.

@jasmussen jasmussen closed this Oct 20, 2017
@jasmussen jasmussen deleted the try/inserter-polish branch October 20, 2017 10:48
ceyhun pushed a commit that referenced this pull request Apr 22, 2020
* Release v1.26.0 (#2153)

* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <chip.snyder3@gmail.com>
Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: jbinda <jakub.binda@gmail.com>
Co-authored-by: Chip <chip.snyder@automattic.com>
Co-authored-by: Maxime Biais <maxime.biais@gmail.com>
Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com>
Co-authored-by: Klymentiy Haykov <forsver@gmail.com>
Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>

* Update gb ref

Co-authored-by: Chip Snyder <chip.snyder3@gmail.com>
Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: jbinda <jakub.binda@gmail.com>
Co-authored-by: Chip <chip.snyder@automattic.com>
Co-authored-by: Maxime Biais <maxime.biais@gmail.com>
Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com>
Co-authored-by: Klymentiy Haykov <forsver@gmail.com>
Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Tug added a commit that referenced this pull request May 12, 2020
* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <chip.snyder3@gmail.com>
Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: jbinda <jakub.binda@gmail.com>
Co-authored-by: Chip <chip.snyder@automattic.com>
Co-authored-by: Maxime Biais <maxime.biais@gmail.com>
Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com>
Co-authored-by: Klymentiy Haykov <forsver@gmail.com>
Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants