Implement initial styling of navigation menu screen #21314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
talldan
requested review from
draganescu,
adamziel,
karmatosed,
noisysocks and
tellthemachines
|
Size Change: +343 B (0%) Total Size: 884 kB
ℹ️ View Unchanged
|
mtias
approved these changes
Apr 1, 2020
I think this is the right thing to do. Over time I'd like to see |
noisysocks
approved these changes
Apr 2, 2020
| } ) ) } | ||
| onChange={ ( selectedMenuId ) => setMenuId( selectedMenuId ) } | ||
| /> | ||
| <Card className="edit-navigation-menus-editor__menu-selection-card"> |
|
Let's get this in and iterate. It's a huge improvement that brings us closer to being able to test this new screen on users. I created #21337 to track making this screen responsive. @karmatosed: If there's any design feedback here, plop it into the project board and we'll get it sorted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #21284
I've implemented this using
@wordpress/componentscomponents, some of which look different from #21284, just because of the styles of the components.We'd have to decide if we want to create variations of the styles those components offer or just stick with the out of the box styles.
There's also a question over whether some of the layout makes semantic sense. E.g. a Save Button in a Panel title.
These things can be iterated on.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: