Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint-md section to scripts readme #19716

Merged
merged 4 commits into from
Jan 17, 2020
Merged

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Jan 17, 2020

Description

Update scripts readme with a lint-md section, this should have been included with #19518

How has this been tested?

Documentation, adds section about running lint-md that matches the other sections. It was added where it was to follow the alphabetical order of the other lint-* rules

Types of changes

Documentation.

@mkaz mkaz added [Type] Developer Documentation Documentation for developers [Package] Scripts /packages/scripts labels Jan 17, 2020
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including docs 👍

Would you mind adding also an entry in New Features section in the CHANGELOG file?

@gziolo gziolo merged commit eaf6937 into master Jan 17, 2020
@gziolo gziolo deleted the add/scripts-lint-md-readme branch January 17, 2020 09:48
@gziolo
Copy link
Member

gziolo commented Jan 17, 2020

I applied some tweaks to the CHANGELOG file before merging.

Some great addition coming up in the next package release. Great work @mkaz and @jorgefilipecosta 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants