Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page attributes menu order to sidebar #1957

Merged
merged 3 commits into from
Jul 26, 2017
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Jul 20, 2017

Partially addresses #991

This pull request seeks to add a Page Attributes panel to the sidebar for post types supporting the page-attributes support type.

Page Attributes

Testing instructions:

Verify that a Page Attributes panel is shown for post types supporting page-attributes, and not shown for other post types. Ensure that only valid input (numbers) is accepted, and that the value is persisted when saving the post.

  1. Navigate to Pages > All Pages
  2. Hover an existing Page and click Gutenberg
  3. In sidebar, note Page Attributes panel
  4. Expand Page Attributes and enter numeric order
  5. Press Save
  6. Refresh page
  7. Note order persisted
  8. Repeat steps 1 - 3 for Posts, noting that Page Attributes is not present

Ensure that unit tests pass:

npm run test-unit editor/sidebar/page-attributes/test/index.js

@aduth aduth added the General Interface Parts of the UI which don't fall neatly under other labels. label Jul 20, 2017
@jasmussen
Copy link
Contributor

Nice work! Your testing instructions pass for me 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants