Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds tests for horizontal mover descriptions #19549

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Adds tests for horizontal mover descriptions #19549

merged 1 commit into from
Jan 10, 2020

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Jan 10, 2020

Description

Adds unit test coverage for horizontal mover descriptions

Types of changes

Non-breaking task

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@talldan talldan added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jan 10, 2020
@talldan talldan self-assigned this Jan 10, 2020
This was referenced Jan 10, 2020
Closed
Merged
MarcoZehe
MarcoZehe approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@MarcoZehe MarcoZehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@talldan talldan merged commit a6530ad into master Jan 10, 2020
@talldan talldan deleted the add/tests-for-horizontal-mover-description branch January 10, 2020 08:36
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoZehe MarcoZehe MarcoZehe approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@talldan talldan

Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Gutenberg 7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@talldan @MarcoZehe @ellatrix