Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting of source in markdown files #19518

Merged
merged 6 commits into from
Jan 9, 2020
Merged

Add linting of source in markdown files #19518

merged 6 commits into from
Jan 9, 2020

Commits on Jan 8, 2020

  1. Add linting of markdown files 

    Adds eslint-plugin-markdown https://github.com/eslint/eslint-plugin-markdown
This allows for linting of code blocks marked js, javascript, or jsx if
a code block is not marked it is skipped.
    @mkaz
    mkaz committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    a9a837b View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Extension not needed, specified on command-line

    @mkaz
    mkaz committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    5846c44 View commit details
    Browse the repository at this point in the history

  2. Update package.json 

    Co-Authored-By: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
    @mkaz @gziolo
    mkaz and gziolo committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    7aff90c View commit details
    Browse the repository at this point in the history

  3. Create and use new eslint config for markdown 

    - Creates a new eslintrc-md.js config for use for markdown docs

- The lint-md command uses this config unless another is specified

- The config allows for undef and unused vars due to docs contain
snippets of code that may be incomplete
    @mkaz
    mkaz committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    97287c0 View commit details
    Browse the repository at this point in the history

  4. Since using separate config, no change needed

    @mkaz
    mkaz committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    5d9922c View commit details
    Browse the repository at this point in the history

  5. Dont need markdown in main, its in wp-scripts

    @mkaz
    mkaz committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    630ee71 View commit details
    Browse the repository at this point in the history