Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] rich text focus loop #19240

Merged
merged 5 commits into from
Jan 7, 2020
Merged

[FIX] rich text focus loop #19240

merged 5 commits into from
Jan 7, 2020

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Dec 19, 2019 •
edited
Loading

Description

This PR contains also changes from #19234

Gutenberg-mobile PR - wordpress-mobile/gutenberg-mobile#1702

This is an only iOS issue. Aztec doesn't trigger the onChange event with the new value when lost its focus while the suggestion is visible. We see the text from autocorrection but we have te written value in the store. The workaround for this is to pass text to the onBlur and update the value on the JS side if that one from onBlur is different.

How has this been tested?

Tested with the steps in wordpress-mobile/gutenberg-mobile#1696

  • Have a media-text block
  • Start typing some text in the paragraph until iOS suggests a completion
  • Tap on the image
  • There should not be a focus loop
  • Switch to HTML mode and check if the text in the paragraph is correct

Please try 2 different scenarios:

  • text from autocorrection has the same length as written text
  • text from autocorrection has a different length as written text

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@dratwas dratwas changed the title check if onBlur event contains text that is different than value [FIX] rich text focus loop Dec 19, 2019
@dratwas dratwas mentioned this pull request Dec 19, 2019
Merged
2 tasks
@dratwas dratwas added the [Package] Rich text /packages/rich-text label Dec 20, 2019
pinarol
pinarol approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Tested with steps here on both WPAndroid and WPiOS.

@dratwas dratwas changed the base branch from master to rnmobile/release-v1.20.0 January 7, 2020 09:58
@dratwas dratwas merged commit 3eaa314 into rnmobile/release-v1.20.0 Jan 7, 2020
@dratwas dratwas deleted the fix/rich-text-loop branch January 7, 2020 17:13
@Tug Tug mentioned this pull request Jan 10, 2020
Merged
6 tasks
Tug added a commit that referenced this pull request Jan 10, 2020
@Tug @lukewalczak
@dratwas @koke
[RNMobile] Merge mobile release v1.20.0 back into master (#19562)
041394d 
* styling fixes after navigation feature merge (#19455)

* Styling fixes to navigation feature

* Add netural styles for toolbar

* Fix condition for not registered component

* Display 'Unsupported' in breadcrumbs for missing components

* Refactor after CR

* Remove leftovers

* [FIX] rich text focus loop (#19240)

* check if onBlur event contains text that is different than value

* add check if there is a text in native event

* Prevent re-selection of RichText when native selection changes as a result of resigning focus

* Fix typo

* Check if isSelected only in onSelectionChangeFromAztec

Co-authored-by: Jorge Bernal <jbernal@gmail.com>

* [RNMobile] Correct displaying photo during upload (#19502)

* [RNMobile] Fix crash once adding Group (#19457)

* Add extra branch for travis to run tests onto

Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com>
Co-authored-by: Jorge Bernal <jbernal@gmail.com>
This was referenced Jan 10, 2020
Closed
Merged
Tug added a commit that referenced this pull request Jan 14, 2020
@Tug @lukewalczak
@dratwas @koke
[RNMobile] Merge mobile release v1.20.0 back into master (step 2) (#1…
adaae10 
…9569)

* [RNMobile] Merge mobile release v1.20.0 back into master (#19562)

* styling fixes after navigation feature merge (#19455)

* Styling fixes to navigation feature

* Add netural styles for toolbar

* Fix condition for not registered component

* Display 'Unsupported' in breadcrumbs for missing components

* Refactor after CR

* Remove leftovers

* [FIX] rich text focus loop (#19240)

* check if onBlur event contains text that is different than value

* add check if there is a text in native event

* Prevent re-selection of RichText when native selection changes as a result of resigning focus

* Fix typo

* Check if isSelected only in onSelectionChangeFromAztec

Co-authored-by: Jorge Bernal <jbernal@gmail.com>

* [RNMobile] Correct displaying photo during upload (#19502)

* [RNMobile] Fix crash once adding Group (#19457)

* Add extra branch for travis to run tests onto

Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com>
Co-authored-by: Jorge Bernal <jbernal@gmail.com>

* Revert travis changes

Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com>
Co-authored-by: Jorge Bernal <jbernal@gmail.com>
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
hypest added a commit that referenced this pull request Feb 11, 2020
@hypest @Tug
@lukewalczak @dratwas @koke @etoledom @mkevins @chipsnyder
[RNMobile] Bring release v1.22.0 to master (#20155)
7dda20a 
* [RNMobile] Merge mobile release v1.20.0 back into master (#19562)

* styling fixes after navigation feature merge (#19455)

* Styling fixes to navigation feature

* Add netural styles for toolbar

* Fix condition for not registered component

* Display 'Unsupported' in breadcrumbs for missing components

* Refactor after CR

* Remove leftovers

* [FIX] rich text focus loop (#19240)

* check if onBlur event contains text that is different than value

* add check if there is a text in native event

* Prevent re-selection of RichText when native selection changes as a result of resigning focus

* Fix typo

* Check if isSelected only in onSelectionChangeFromAztec

Co-authored-by: Jorge Bernal <jbernal@gmail.com>

* [RNMobile] Correct displaying photo during upload (#19502)

* [RNMobile] Fix crash once adding Group (#19457)

* Add extra branch for travis to run tests onto

Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com>
Co-authored-by: Jorge Bernal <jbernal@gmail.com>

* Adding empty function to RichText children call. (#19818)

This fixes a crash originated on this PR:
#19536
`

* Disable gallery image size options on mobile (#19828)

* [Mobile] Fix blank image size labels on mobile (#19800) (#20045)

* Fix blank image size labels on mobile

* Use name instead of label in default imageSizes

* [RNMobile] Enable Dismiss on PlainText in Android (#20095)

* Add flag for determining if running on Android

* Enable Dismiss button on PlainText. Enable show keyboard in Android on PlainText mount

* Enable Dismiss button on PlainText. Enable show keyboard in Android on PlainText mount

Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com>
Co-authored-by: Jorge Bernal <jbernal@gmail.com>
Co-authored-by: etoledom <etoledom@icloud.com>
Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com>
Co-authored-by: Chip <chip.snyder3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees
No one assigned
Labels
[Package] Rich text /packages/rich-text
Projects
None yet
Milestone
Gutenberg 7.3
Development

Successfully merging this pull request may close these issues.
4 participants
@dratwas @pinarol @ellatrix @koke