Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP sub nav fixes for navigation block #18382

Closed
wants to merge 1 commit into from
Closed

Conversation

karmatosed
Copy link
Member

@karmatosed karmatosed commented Nov 7, 2019

This has a little nicer dropdown, however, isn't complete and a work in progress for now. This will fix #18310 once done.

image

To do:

  • Mobile styling.
  • Make arrow indicator change styles.
  • Fix bottom margin issue.
  • Test with multiple sub menus.
  • Iterate design to have less spacing and no text underline.

To test:

  • Multiple themes.
  • Mobile devices.

Note: the idea is to have a drop-down with no JS so keeping it simple.

Once that is done then code review.

@karmatosed karmatosed changed the title WIP dropdown fixes for navigation block WIP sub nav fixes for navigation block Nov 8, 2019
visibility: hidden;

&::before {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these styles should likely be added within the theme.scss styles, which is what gets loaded when a theme does add_theme_support( 'wp-block-styles' ). Particularly the ones that are harder to replace, like ::before.

@karmatosed
Copy link
Member Author

I am going to close this in favour of #18350 as can then work off it.

@karmatosed karmatosed closed this Nov 8, 2019
@aristath aristath deleted the try/dropdown-styling branch November 10, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Block: sub-menu items design
2 participants