NavigationMenu: set appender color

[retrofox]

Description

It sets the appender color when the navigation menu has defined a text color.

How has this been tested?

Apply text color from the colors selector and confirm that the color is being applied at the appender as well.

Screenshots

before

after

Checklist:

• My code is tested.
• My code follows the WordPress code style.

[obenland]

By adjusting the appender color we set ourselves up for a situation where the contrast with the background is so low that it won't be visible and hampers usability.

I wonder if instead, we should give it a white or black background and border and keep it the opposite color to make it always visible. Something like this?

[draganescu]

I added the design labels as this might be an approach that impacts future blocks as well.

[draganescu]

the code is fine, but the solution needs to be confirmed by some design argument.

[retrofox]

Testing with twenty-twenty I see how that the appender looks, pretty similar how @obenland mentioned before:

[karmatosed]

I like the idea of a white background for it, means it's more consistent with expected appenders. My only wonder is other appenders on that page might not have it.

This is an example.

We do seem to colour one and not the other so there might be history there we can fall on:

[retrofox]

I like the idea of a white background for it, means it's more consistent with expected appenders. My only wonder is other appenders on that page might not have it.

Right, consistency is a valid point. Coloring the appender with the text color (first approach on this PR) maybe make more sense?

[karmatosed]

Right, consistency is a valid point. Coloring the appender with the text color (first approach on this PR) maybe make more sense?

This feels like maybe best yes.

[apeatling]

The one issue with using text color is that it might still have low contrast if the user selects a low contrast text color. Having said that since it's a user selection I think that seems okay.

[retrofox]

The one issue with using text color is that it might still have low contrast if the user selects a low contrast text color. Having said that since it's a user selection I think that seems okay.

Yes, any control should be accessible beyond the user customization. Maybe, by mistake, the user sets a wrong combination and stop seeing the appender button. Anyway, this possibility can happen in the current implementation.

[retrofox]

Also, we should keep in mind the probably the styles will change soon according to changes suggested here #19681

[shaunandrews]

I wonder if instead, we should give it a white or black background and border and keep it the opposite color to make it always visible.

I think this is the best solution. This is how the inserter works normally when using a theme with a dark background, always showing a white background behind the + icon.

[jasmussen]

Since the appender now has a black background, can we close this one?

[draganescu]

Yes.