Fix Block Controls behavior for List Block. #17876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When toggling between Bulleted List and Numbered List, the Block Controls for List block disappears. You have to click inside the block to get them back. Ideally, the Block Controls should always be present, if the block is selected.
desaiuditd
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
ellatrix
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
It looks like previously we used isSelected, which would still be true when the focus has left the rich text field. Omitting this condition entirely seems fine because there's only one rich text field in the block, and because the controls are for both the rich text field and the block.
|
Might be good to include this for WP 5.3 since it's a small regression from WP 5.2. |
gziolo
added
[Type] Bug
gziolo
pushed a commit
that referenced
this pull request
Oct 15, 2019
When toggling between Bulleted List and Numbered List, the Block Controls for List block disappears. You have to click inside the block to get them back. Ideally, the Block Controls should always be present, if the block is selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When toggling between Bulleted List and Numbered List, the Block Controls for List block disappears. You have to click inside the block to get them back. Ideally, the Block Controls should always be present, if the block is selected.
This seems to be introduced with #16962. Not sure if this behaviour is intentional or it's a legit bug. Happy to decline this PR if there's a reasoning behind current behaviour. @ellatrix would know better here.
How has this been tested?
After the fix is applied, the Block Controls always stays in the toolbar. So that I can easily toggle between Bulleted/Numbered List.
Screenshots
Before
After
Types of changes
Checklist: