Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Add content alignment options to paragraph block #17577

Merged
merged 1 commit into from
Nov 6, 2019
Merged

[RNMobile] Add content alignment options to paragraph block #17577

merged 1 commit into from
Nov 6, 2019

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Sep 25, 2019 •
edited
Loading

related gutenberg-mobile PR

Description

This PR adds alignment controls for paragraph blocks on mobile, addressing gutenberg-mobile#1266.

iOS Android
p_alignment_ios mov p_alignment_android mp4

How has this been tested?

  1. Open a paragraph block
  2. Adjust its alignment a few times
  3. Verify that both the display of the text and the html is updated appropriately after each change
  4. Verify that a block with alignment can be saved and loaded on web with the alignment reflected
  5. Adjust the block's alignment on the web
  6. Verify that the block can be saved on web and loaded on mobile with the alignment reflected

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@mchowning mchowning mentioned this pull request Sep 25, 2019
Merged
1 task
@gziolo gziolo added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Sep 26, 2019
@mchowning mchowning force-pushed the rnmobile/1266_add_content_alignment_to_paragraphs branch from e562a01 to a6b0e00 Compare September 27, 2019 16:38
@mchowning mchowning changed the base branch from rnmobile/master to master September 27, 2019 16:40
@mchowning mchowning force-pushed the rnmobile/1266_add_content_alignment_to_paragraphs branch from a6b0e00 to 01a2344 Compare September 27, 2019 16:41
@mchowning mchowning mentioned this pull request Oct 1, 2019
Closed
@mchowning mchowning force-pushed the rnmobile/1266_add_content_alignment_to_paragraphs branch from 01a2344 to e167910 Compare October 18, 2019 20:04
@mchowning mchowning changed the title [RNMobile] Add content alignment options to paragraph block [RNMobile] Add content alignment options to paragraph block on Android Oct 18, 2019
@mchowning mchowning mentioned this pull request Oct 21, 2019
Merged
@mchowning mchowning force-pushed the rnmobile/1266_add_content_alignment_to_paragraphs branch from 20ea4f0 to 6c3526a Compare October 23, 2019 17:23
@mchowning mchowning changed the title [RNMobile] Add content alignment options to paragraph block on Android [RNMobile] Add content alignment options to paragraph block Oct 23, 2019
@mchowning mchowning marked this pull request as ready for review October 23, 2019 17:49
@mchowning mchowning mentioned this pull request Oct 23, 2019
Merged
1 task
marecar3
marecar3 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mchowning!
LGTM!

@mchowning mchowning force-pushed the rnmobile/1266_add_content_alignment_to_paragraphs branch from 6c3526a to 23274e6 Compare November 5, 2019 19:54
@mchowning mchowning force-pushed the rnmobile/1266_add_content_alignment_to_paragraphs branch from 23274e6 to 436dd52 Compare November 6, 2019 18:48
@mchowning mchowning changed the base branch from master to rnmobile/release/1.16.1 November 6, 2019 18:49
@mchowning mchowning changed the base branch from rnmobile/release/1.16.1 to rnmobile/release-1.16.1 November 6, 2019 18:50
@mchowning mchowning merged commit 8b615ac into rnmobile/release-1.16.1 Nov 6, 2019
@mchowning mchowning deleted the rnmobile/1266_add_content_alignment_to_paragraphs branch November 6, 2019 18:51
@mchowning mchowning restored the rnmobile/1266_add_content_alignment_to_paragraphs branch November 6, 2019 19:46
@mchowning mchowning mentioned this pull request Nov 11, 2019
Merged
@aristath aristath deleted the rnmobile/1266_add_content_alignment_to_paragraphs branch November 10, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@etoledom etoledom Awaiting requested review from etoledom

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchowning @marecar3 @gziolo