Chore: Align the version of lodash with WordPress core #17528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
adamsilverstein,
aduth,
ajitbohra,
atimmer,
chrisvanpatten,
daniloercoli,
ellatrix,
etoledom,
jorgefilipecosta,
nerrad,
noisysocks,
oandregal,
ntwb,
SergioEstevao,
Soean,
swissspidy,
talldan,
TimothyBJacobs and
youknowriad
as code owners
gziolo
added
[Type] Code Quality
gziolo
changed the title
ntwb
approved these changes
Sep 24, 2019
gziolo
force-pushed
the
update/lodash
branch
2 times, most recently
from
350468f
to
e17f4f1
Compare
|
A few e2e tests are failing which is very surprising. @youknowriad - any ideas what could happen? |
gziolo
force-pushed
the
update/lodash
branch
from
e17f4f1
to
f391e81
Compare
youknowriad
pushed a commit
that referenced
this pull request
Sep 30, 2019
youknowriad
pushed a commit
that referenced
this pull request
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WordPress core is going to use
lodashv4.17.15 in the upcoming 5.3 release:https://github.com/WordPress/wordpress-develop/blob/42b5133a2557c0fd58dae731d8694408133ea339/src/wp-includes/script-loader.php#L93-L103
This PR tries to align Gutenberg and core in that regard.