Writing Flow/Quote: allow splitting #17121

ellatrix · 2019-08-21T09:10:06Z

Description

Allows the quote block to be split when the caret is at an empty paragraph. This is similar to how list splitting works. The implementation is really simple.

How has this been tested?

I've added e2e tests.

Screenshots

Types of changes

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.

youknowriad · 2019-08-21T09:30:54Z

packages/block-library/src/quote/index.js

 		if ( ! value || value === '<p></p>' ) {
 			return {
 				...attributes,
-				citation: attributes.citation + citation,
+				citation,
 			};
 		}

 		return {
 			...attributes,
 			value: attributes.value + value,


Should we append the first citation between the two values here?

It feels a bit strange to me. :) If you split a quote into two quotes and merge them, you end up with a cite as quote content? In that case I would expect them to get merged in the original form. But maybe that's ok, then it requires a few more backspaces to restore. :)

Yes, I'm not sure either, I guess I "just" wanted to avoid losing that text but it probably doesn't make a lot of sense.

I agree with trying to avoid data loss. If the merge wasn't good, the user could always revert though. Something else we could do is ask the user which citation to use in case there are two. Kind of like a merge conflict in git. :) This pattern might also be useful to other blocks.

youknowriad

There are some failing tests, but I like how this feels.

ellatrix · 2019-08-21T09:40:05Z

Seems to be intermittent. Restarted the tests. :)

ellatrix · 2019-08-21T11:57:18Z

Always running into this error. No idea what's going wrong.


532$ npm run check-local-changes
533
534> gutenberg@6.3.0 precheck-local-changes /home/travis/build/WordPress/gutenberg
535> npm run docs:build
536
537
538> gutenberg@6.3.0 docs:build /home/travis/build/WordPress/gutenberg
539> node ./docs/tool/index.js && node ./bin/update-readmes.js
540
541
542/home/travis/build/WordPress/gutenberg/docs/tool/update-data.js:48
543			throw stderr.toString();
544			^
545internal/modules/cjs/loader.js:638
546    throw err;
547    ^
548
549Error: Cannot find module 'espree'

ellatrix · 2019-08-21T12:07:42Z

Did a fresh npm install and this error doesn't occur locally.

mtias · 2019-08-21T12:21:29Z

Thanks! This has been a small annoyance for a bit.

youknowriad · 2019-08-21T14:51:29Z

I think @pento mentioned issues with the last npm release. So it might be related.

ellatrix · 2019-08-21T21:42:16Z

Only "Build artifacts" is failing because of some issues with npm. I manually verified that there are no build artefacts.

gziolo · 2019-08-26T08:31:55Z

Cool to see this enhancement merged :)

I'd love to see it replicated in all "text" blocks. @ellatrix, do you plan to add it to more blocks? It looks like using this unstable API would allow us to have a couple of working examples before even start thinking about its final shape.

ellatrix · 2019-08-26T09:07:34Z

Yes, I do, but other normal text field might require a little more work. E.g. #16990 has helped. The unstable API is only for multi line instances. The future of multi line is uncertain which is why it is unstable.

* Writing Flow/Quote: allow splitting * Add extra merge e2e test

into rnmobile/add-autosave-to-mobile * 'rnmobile/master' of https://github.com/WordPress/gutenberg: (52 commits) [RNMobile] DarkMode improvements (#17309) Remove redundant bg color within button appender (#17325) Support group block on mobile (#17251) [RNMobile] Insure tapping at end of post inserts at end Recover border colors (#17269) [RNMobile] Fix dismiss keyboard button for the post title (#17260) Unify media placeholder and upload props within media-text (#17268) MediaUpload and MediaPlaceholder unify props (#17145) Add native support for the MediaText block (#16305) Activate Travis CI on rnmobile/master branch (#17229) [RNMobile] Native mobile release v1.11.0 (#17181) Apply box-sizing border-box properly to the notices components (#17066) Writing Flow: allow undo of patterns with BACKSPACE and ESC (#14776) Project automation: Rewrite actions using JavaScript (#17080) Build: remove global install of latest npm since we want to use the paired node/npm version (#17134) Writing Flow/Quote: allow splitting (#17121) Use `400` as a valid `font-weight` Add: Disabled block count in the block manager (#17103) Update video player style on mobile - Add a new gridicon play icon, from: https://github.com/Automattic/gridicons/blob/87c9fce08b4a9f184b9fb4963228757fdd4f4e74/svg-min/gridicons-play.svg - Replace the Dashicon play by this one - Update icon size and icon color - Update the overlay color [RNMobile] Hide replaceable block when adding block (#16931) ... # Conflicts: # packages/block-editor/src/components/block-list/index.native.js # packages/block-editor/src/components/inserter/index.native.js # packages/block-editor/src/components/inserter/menu.native.js # packages/block-editor/src/components/media-placeholder/index.native.js # packages/block-editor/src/components/warning/index.native.js # packages/block-library/src/code/edit.native.js # packages/block-library/src/image/edit.native.js # packages/block-library/src/missing/edit.native.js # packages/block-library/src/more/edit.native.js # packages/block-library/src/nextpage/edit.native.js # packages/block-library/src/video/edit.native.js # packages/components/src/mobile/bottom-sheet/cell.native.js # packages/components/src/mobile/bottom-sheet/index.native.js # packages/components/src/mobile/dark-mode/index.native.js # packages/components/src/mobile/html-text-input/index.native.js # packages/components/src/toolbar/toolbar-container.native.js # packages/edit-post/src/components/header/header-toolbar/index.native.js # packages/edit-post/src/components/layout/index.native.js # packages/edit-post/src/components/visual-editor/index.native.js # packages/rich-text/src/component/index.native.js

ellatrix added the [Block] Quote Affects the Quote Block label Aug 21, 2019

ellatrix requested review from ajitbohra, gziolo, jorgefilipecosta, nerrad, ntwb, Soean and talldan as code owners August 21, 2019 09:10

ellatrix requested a review from mapk August 21, 2019 09:12

ellatrix mentioned this pull request Aug 21, 2019

Block library: When pressing enter on empty line new Paragraph blocks is crated #16880

Closed

5 tasks

youknowriad reviewed Aug 21, 2019

View reviewed changes

youknowriad approved these changes Aug 21, 2019

View reviewed changes

ellatrix added 2 commits August 21, 2019 13:15

Writing Flow/Quote: allow splitting

8f01df9

Add extra merge e2e test

edfeb43

ellatrix force-pushed the try/quote-split branch from 71f9787 to edfeb43 Compare August 21, 2019 11:16

ellatrix added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Aug 21, 2019

ellatrix merged commit 1aecff9 into master Aug 21, 2019

ellatrix deleted the try/quote-split branch August 21, 2019 21:42

ellatrix added this to the Gutenberg 6.4 milestone Aug 22, 2019

donmhico pushed a commit to donmhico/gutenberg that referenced this pull request Aug 27, 2019

Writing Flow/Quote: allow splitting (WordPress#17121)

ac95cf6

* Writing Flow/Quote: allow splitting * Add extra merge e2e test

gziolo pushed a commit that referenced this pull request Aug 29, 2019

Writing Flow/Quote: allow splitting (#17121)

4868a8b

* Writing Flow/Quote: allow splitting * Add extra merge e2e test

gziolo pushed a commit that referenced this pull request Aug 29, 2019

Writing Flow/Quote: allow splitting (#17121)

a022736

* Writing Flow/Quote: allow splitting * Add extra merge e2e test

gziolo mentioned this pull request Oct 24, 2019

Overview: RichText, APIs, & Formatting Library #13778

Closed

17 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Writing Flow/Quote: allow splitting #17121

Writing Flow/Quote: allow splitting #17121

ellatrix commented Aug 21, 2019 •

edited

Loading

youknowriad Aug 21, 2019

ellatrix Aug 21, 2019

youknowriad Aug 21, 2019

ellatrix Aug 21, 2019

youknowriad left a comment

ellatrix commented Aug 21, 2019

ellatrix commented Aug 21, 2019

ellatrix commented Aug 21, 2019

mtias commented Aug 21, 2019

youknowriad commented Aug 21, 2019

ellatrix commented Aug 21, 2019

gziolo commented Aug 26, 2019

ellatrix commented Aug 26, 2019

Writing Flow/Quote: allow splitting #17121

Writing Flow/Quote: allow splitting #17121

Conversation

ellatrix commented Aug 21, 2019 • edited Loading

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

youknowriad Aug 21, 2019

Choose a reason for hiding this comment

ellatrix Aug 21, 2019

Choose a reason for hiding this comment

youknowriad Aug 21, 2019

Choose a reason for hiding this comment

ellatrix Aug 21, 2019

Choose a reason for hiding this comment

youknowriad left a comment

Choose a reason for hiding this comment

ellatrix commented Aug 21, 2019

ellatrix commented Aug 21, 2019

ellatrix commented Aug 21, 2019

mtias commented Aug 21, 2019

youknowriad commented Aug 21, 2019

ellatrix commented Aug 21, 2019

gziolo commented Aug 26, 2019

ellatrix commented Aug 26, 2019

ellatrix commented Aug 21, 2019 •

edited

Loading