Add/mobile fullscreen image preview #17109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-modal, modeled after BottomSheet usage
talldan
added
[Type] Enhancement
mtias
added
the
Mobile App - i.e. Android or iOS
…andscape. Removed unnecessary code.
cameronvoell
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
talldan and
youknowriad
as code owners
Tug
reviewed
Aug 23, 2019
Tug
reviewed
Aug 23, 2019
Tug
reviewed
Aug 23, 2019
Tug
reviewed
Aug 23, 2019
Tug
requested changes
Aug 23, 2019
There was a problem hiding this comment.
Great work so far @cameronvoell !
I had a few comments on the code that I think we should address, otherwise this is very good for a v1 imo
cameronvoell
force-pushed
the
add/mobile-fullscreen-image-preview
branch
from
64e25d4
to
3e8445a
Compare
…er of onDimensionsChanged
cameronvoell
force-pushed
the
add/mobile-fullscreen-image-preview
branch
from
3e8445a
to
3b3f645
Compare
…removing utils class since it is not being used anywhere else.
…r, perhaps becauser we have no children tap events we need to worry about. Fixed animationOutTiming constant.
cameronvoell
force-pushed
the
add/mobile-fullscreen-image-preview
branch
from
1c0cca8
to
9d3bbab
Compare
Tug
reviewed
Aug 27, 2019
* [RNMobile] Fix crash when adding separator * Build: remove global install of latest npm since we want to use the paired node/npm version (WordPress#17134) * Build: remove global install of latest npm since we want to use the paired node/npm version * Also update travis to remove --latest-npm flag * [RNMobile] Try dark mode (iOS) (WordPress#17067) * Adding dark mode component implemented on list and list block * Adding DarkMode handling to RichText, ToolBar and SafeArea * Mobile: Using DarkMode as HOC * iOS DarkMode: Modified colors on block list and block container * iOS DarkMode: Improved Header Toolbar colors * iOS DarkMode: Removing background from buttons * iOS DarkMode warning and unsupported * iOS DarkMode: MediaPlaceholder * iOS DarkMode: BottomSheets * iOS DarkMode: Inserter * iOS DarkMode: DefaultBlockAppender * iOS DarkMode: PostTite * Update hardcoded colors with variables * iOS DarkMode: Fix bottom-sheet cell value color * iOS DarkMode: More - PageBreak - Add Block Here * iOS DarkMode: Better text color * iOS Darkmode: Code block * iOS DarkMode: HTML View * iOS DarkMode: Improve colors on SafeArea * Fix toolbar not avoiding keyboard regression * Fix native unit tests * Fix gutenberg-mobile unit tests * Adding RNDarkMode mocks * RNMobile: Fix crash when viewing HTML on iOS * [RNMobile] Remove toolbar from html view * [RNMobile] Fix MaxListenersExceededWarning caused by dark-mode event emitter (WordPress#17186) * Fix MaxListenersExceededWarning caused by dark-mode event emitter * Checking for setMaxListeners trying to avoid CI error * Adding remove listener to DarkMode HOC * DarkMode: Binding this.onModeChanged to `this` * DarkMode: Adding conditional needed to pass UI Tests on CI * Fix focus title on new posts regression (WordPress#17180) * BottomSheet: Setting DashIcon color directly when theme is default (light) (WordPress#17193)
* First working version of the MediaText component for native mobile * Fix adding a block to an innerblock list * Disable mediaText on production * MediaText native: improve editor visuals * Move BlockToolbar from BlockList to Layout * Remove BlockEditorProvider from BlockList and add native version of EditorProvider to Editor. Plus support InsertionPoint and BlockListAppender * Update BlockMover for native to hide if locked or if it's the only block * Make the vertical align button work, add more styling options for toolbar buttons * Make sure registerCoreBlocks does not break in production * Copy docblock comment from the web version for registerCoreBlocks * Fix focusing on the media placeholder * Only support adding image for now * Update usage of MediaPlaceholder in MediaContainer * Enable autoScroll for just the out most block list * Fix JS Unit tests * Roll back to IconButton refactor and fix tests * Fix BlockVerticalAlignmentToolbar buttons style on mobile * Fix thing for web and ensure ariaPressed is always passed down * Use AriaPressed directly to style SVG on mobile * Update snapshots
cameronvoell
requested review from
adamsilverstein,
aduth,
atimmer,
daniloercoli,
dmsnell,
etoledom,
karmatosed,
mapk,
mkaz,
mmtr,
nerrad,
noisysocks,
oandregal,
ntwb,
SergioEstevao,
swissspidy and
TimothyBJacobs
as code owners
This was referenced Nov 1, 2019
|
Closed in favor of native solution. More info: wordpress-mobile/gutenberg-mobile#1286 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR covers fullscreen image preview in the gutenberg mobile editor as specified in gb-mobile issue 1286
WP iOS PR for testing: wordpress-mobile/WordPress-iOS#12834
Remaining tasks:
Decided to commit behind a
__DEV__flag until rotation issues are resolved. Tasks below will be in a future PR.4. Address dependency on Fix for Android modal rotation crash (wp-mobile PR 10383)
5. (•••) Button over Image
6. (•••) Button leads to BottomSheet with Edit and ViewFullscreen options
How has this been tested?
Tested as a submodule to gutenberg-mobile repo at latest develop (cf27fba )
Test steps:
*Note you can also test rotating the device while in fullscreen preview, but there is a known issue that will cause the image preview to close on rotate when testing in WordPress Android on a phone running API 28 - See WordPress Android issues 10227 and 1333
Screenshots
Fade in to fullscreen image preview:
Types of changes
New feature - this code updates the image block of the mobile editor so that users can do a fullscreen preview of the image that they are adding.
Checklist: