Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality of table e2e tests #16872

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Improve code quality of table e2e tests #16872

merged 1 commit into from
Aug 2, 2019

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Aug 2, 2019 •
edited
Loading

Description

Small PR that implements some code quality updates for table block e2e tests. Addresses feedback on #16653 and #16111.

Changes:

  • Use the clickButton utility instead of elementHandle.click.
  • Avoid typing loads of text when line breaks can be used.
  • Prefer array destructuring when possible.
  • Fix an incorrect comment.

How has this been tested?

  • Ensure E2E tests pass.

Types of changes

Code quality.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@talldan talldan added [Type] Code Quality Issues or PRs that relate to code quality [Block] Table Affects the Table Block labels Aug 2, 2019
@talldan talldan self-assigned this Aug 2, 2019
gziolo
gziolo approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests still pass, code changes look good, nice cleanup 👍

@gziolo gziolo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Aug 2, 2019
@talldan talldan merged commit e73a07a into master Aug 2, 2019
@talldan talldan deleted the update/table-e2e-tests branch August 2, 2019 07:27
@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@talldan @gziolo
Improve code quality of table e2e tests (#16872)
75a921b
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@talldan @gziolo
Improve code quality of table e2e tests (#16872)
1186a38
This was referenced Aug 1, 2024
Open
Open
Open
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@talldan talldan

Labels
[Block] Table Affects the Table Block [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@talldan @gziolo @youknowriad