Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DimensionControl component #16791

Merged
merged 27 commits into from
Oct 28, 2019
Merged

Add DimensionControl component #16791

merged 27 commits into from
Oct 28, 2019

Commits on Oct 28, 2019

  1. Adds initial component 

    Note this is copied wholescale from original PR #16730
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    2fcb86f View commit details
    Browse the repository at this point in the history

  2. Remove redunant files. Refactors tests.

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    56e0670 View commit details
    Browse the repository at this point in the history

  3. Updates docs

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    3f2bade View commit details
    Browse the repository at this point in the history

  4. Checks callbacks are functions prior to calling

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    1acb0a3 View commit details
    Browse the repository at this point in the history

  5. Adds temp testing example usage of component to Group Block

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    51d5575 View commit details
    Browse the repository at this point in the history

  6. Updates to allow sizes as an (optionaly) prop dependency

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    61d25ee View commit details
    Browse the repository at this point in the history

  7. Update default value label

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    09a54ec View commit details
    Browse the repository at this point in the history

  8. Removes unnecessary InstanceId HOC usage 

    Addresses #16791 (comment)
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    0a6864e View commit details
    Browse the repository at this point in the history

  9. Remove unused abbreviation in size table

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    591979c View commit details
    Browse the repository at this point in the history

  10. Revert "Adds temp testing example usage of component to Group Block" 

    This reverts commit 6f9f3bf.
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    46aeac6 View commit details
    Browse the repository at this point in the history

  11. Remove arbitrary size value from sizes list 

    This is not required as we cannot know how the dimensions component will be used. Therefore sticking with relative values via the slugs is safer. These can be mapped on a case by case basis as required.
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    4d21bb7 View commit details
    Browse the repository at this point in the history

  12. Remove icon label for a11y reasons 

    Addresses #16791 (comment)
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    3feb767 View commit details
    Browse the repository at this point in the history

  13. Update component docs for consistency, spelling and grammar

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    da1c0ff View commit details
    Browse the repository at this point in the history

  14. Tweak docblock formats

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    93f5dd1 View commit details
    Browse the repository at this point in the history

  15. Update test snapshots to match new default value

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    93a2929 View commit details
    Browse the repository at this point in the history

  16. Update API from onSpacingChange to more agnostic onChange 

    Addresses #16791 (comment)
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    d3a8924 View commit details
    Browse the repository at this point in the history

  17. Update tests to cover onChange handler renamed

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    196a8ae View commit details
    Browse the repository at this point in the history

  18. Update currentSize prop to value for consistency with other components

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    fc8f003 View commit details
    Browse the repository at this point in the history

  19. Removes onReset in favour of onChange with undefined for consistency 

    Adddresses #16791 (comment)
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    dbe7a4f View commit details
    Browse the repository at this point in the history

  20. Move component to @wordpress/components package

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    d36ac83 View commit details
    Browse the repository at this point in the history

  21. Remove invalid font sizes style import 

    Accidentally included from rebase.
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    4cea8ad View commit details
    Browse the repository at this point in the history

  22. Deps update due to rebase

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    70bc609 View commit details
    Browse the repository at this point in the history

  23. Remove unneeded doc blocks

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    1a4f6af View commit details
    Browse the repository at this point in the history

  24. Remove usage suggestion which was not helpful

    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    f1d67fc View commit details
    Browse the repository at this point in the history

  25. Update readme docs to match current API 

    Addresses #16791 (comment)
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    387a993 View commit details
    Browse the repository at this point in the history

  26. Export as experimental component 

    Addresses #16791 (comment)
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    a0b2dca View commit details
    Browse the repository at this point in the history

  27. Revert "Deps update due to rebase" 

    This reverts commit 95d00f3.

Addresses #16791 (comment)
    @getdave
    getdave committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    d2d8816 View commit details
    Browse the repository at this point in the history