-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First-time contributor github action #16762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
force-pushed
the
add/first-time-contributor-workflow
branch
2 times, most recently
from
July 26, 2019 07:25
9d61df0
to
1db1457
Compare
talldan
commented
Jul 26, 2019
gziolo
added
the
[Type] Project Management
Meta-issues related to project management of Gutenberg
label
Jul 26, 2019
talldan
force-pushed
the
add/first-time-contributor-workflow
branch
4 times, most recently
from
July 30, 2019 08:58
bfee35e
to
9028932
Compare
talldan
force-pushed
the
add/first-time-contributor-workflow
branch
from
July 30, 2019 09:16
9028932
to
dfe852b
Compare
talldan
commented
Jul 30, 2019
|
||
action "First Time Contributor" { | ||
uses = "./.github/actions/first-time-contributor" | ||
needs = ["Filter opened"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing it's ok for two workflows to use the same action?
aduth
approved these changes
Jul 30, 2019
pr_number=$(jq -r '.number' $GITHUB_EVENT_PATH) | ||
|
||
if [ "$pr_number" = "null" ] || [ "$author" = "null" ]; then | ||
echo "Could not find PR number or author. $pr_number / $author" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed whitespace here.
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* First draft of first-time contributor action * Try using the github search api * Minor tweaks
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* First draft of first-time contributor action * Try using the github search api * Minor tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Enhancement
A suggestion for improvement.
[Type] Project Management
Meta-issues related to project management of Gutenberg
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A github action that automatically labels opened pull requests with the 'First-time Contributor' label.
How has this been tested?
Testing isn't straightforward, requires docker locally but here are some steps!
gutenberg
repo.event.json
with the following content:Make sure the
number
field represents the number for the PR created in step 2. Make thelogin
field the random name of a user who has never committed to your fork of gutenberg.public_repo
permission.INSERT_TOKEN_HERE
with your token from step 5 andINSERT_REPO_HERE
with the name of your fork from step 1 (e.g.talldan/gutenberg
)Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: