Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disabled menu item button styles #16581

Merged
merged 2 commits into from
Jul 18, 2019
+8 −0
Merged

Fix disabled menu item button styles #16581

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63d2574
Reintroduce style for disabled menu items
talldan Jul 15, 2019
c4b3c3c
Remove unused style
talldan Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/components/src/dropdown-menu/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,12 @@
padding-left: 0.5rem;
}
}

.components-dropdown-menu__menu-item,
.components-menu-item__button {
&:disabled,
&[aria-disabled="true"] {
opacity: 0.3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this fixed in a more global way @aduth? Should we revert that change in that case as it becomes unnecessary styles?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this treats a symptom of the root issue which is that, as of #16103 (#16103 (comment)), we have no disabled stying for buttons.

I think the changes there (at least this one line) should be reverted, or find another way which treats exceptions to default disabled styling.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #16769

}
}
}