Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Native mobile release v1.8.0 #16344

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Jun 28, 2019

Description

This PR tracks the release v1.8.0 of the native mobile app.

How has this been tested?

Using this gutenberg-mobile side PR: wordpress-mobile/gutenberg-mobile#1172

Types of changes

  1. Disable the video block for ios

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Tug Tug added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jun 28, 2019
@Tug Tug added this to the Future milestone Jun 28, 2019
@Tug Tug requested a review from hypest June 28, 2019 08:40
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed case "B" in wordpress-mobile/WordPress-Android#10092 (comment) with 3fc8ba6. It will be best @Tug if you can share more context of commit f7bbf58 in case I missed something there.

Beyond that, this LGTM.

@hypest hypest merged commit a53a38b into master Jun 28, 2019
@hypest hypest deleted the rnmobile/release-v1.8.0 branch June 28, 2019 17:24
@youknowriad youknowriad modified the milestones: Future, Gutenberg 6.1 Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants