i18n: Bump Tannin dependency to 1.1.0 #16337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Performance
youknowriad
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to bump the Tannin dependency from 1.0.1 to 1.1.0 .
View CHANGELOGS:
tannin@tannin/postfix@tannin/plural-forms@tannin/evaluate@tannin/compileNotably, this includes a couple performance improvements:
plural_formsoption as a function (aduth/tannin@9825ad4). This is particularly useful for the "default" (untranslated) locale, to avoid parsing and computing plural forms using the default'plural=(n!=1)'plural expression.Array#splice(aduth/tannin@50cde55).The performance impact is not expected to be dramatic (it largely affects plurals usage specifically, as singular strings are already optimized to bypass plural expression evaluation). That said, running
npm run test-performanceyields some improvement (~6ms reduction average time to type, from 103.4ms to 97.58ms).Testing Instructions:
There should be no impact on localized strings. Test in both the default (English) locale and a translated (non-English) locale.