Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change unit to e2e tests in parts of scripts package README #16267

Merged
merged 1 commit into from
Jun 25, 2019
Merged

change unit to e2e tests in parts of scripts package README #16267

merged 1 commit into from
Jun 25, 2019

Conversation

Shelob9
Copy link
Contributor

@Shelob9 Shelob9 commented Jun 24, 2019 •
edited by swissspidy
Loading

Description

I changed where the README for @wordpress/scripts refers to e2e tests as unit tests.

Fixes #16264.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ntwb ntwb added [Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers labels Jun 24, 2019
@ntwb ntwb added this to the Gutenberg 6.0 milestone Jun 24, 2019
ntwb
ntwb approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @Shelob9, thanks 👍

@gziolo gziolo removed this from the Gutenberg 6.0 milestone Jun 25, 2019
@gziolo gziolo merged commit 91163be into WordPress:master Jun 25, 2019
@gziolo
Copy link
Member

gziolo commented Jun 25, 2019

Thanks, @Shelob9 :)

@github-actions github-actions bot added this to the Gutenberg 6.1 milestone Jun 25, 2019
@swissspidy
Copy link
Member

Manually closed #16264 now, as the PR didn't contain something like Fixes #16264 which would auto-close it. Something to keep in mind for next time :)

This was referenced Jul 16, 2024
Open
Open
@OKEAMAH OKEAMAH mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb ntwb approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@nerrad nerrad Awaiting requested review from nerrad

@oandregal oandregal Awaiting requested review from oandregal

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 6.1
Development

Successfully merging this pull request may close these issues.

e2e tests are referred to as unit tests in some parts of README
4 participants
@Shelob9 @gziolo @swissspidy @ntwb