Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand explanation of uses for dynamic blocks #16228

Merged
merged 3 commits into from
Jun 29, 2019

Conversation

jodamo5
Copy link
Contributor

@jodamo5 jodamo5 commented Jun 20, 2019

Description

This update gives a clearer explanation of the uses for dynamic blocks. This update especially explains the need to use dynamic blocks if developers want their block updates to be immediately reflected on the front end of the site, instead of Gutenberg's validation process applying.

How has this been tested?

No code has been changed - just the explanation about dynamic blocks.
For the second use-case example that I have added, I have tested this in Wordpress by creating a dynamic block, and have tested the values it saves into the database.

Types of changes

The existing description of dynamic blocks is extremely limited. The fuller explanation I have written gives far more breadth to the use of dynamic blocks.

Gives clearer explanation of dynamic blocks uses. This update especially explains the need to use dynamic blocks if developers want their block updates to be immediately reflected on the front end of the site, instead of Gutenberg's validation process applying.
@gziolo gziolo added [Type] Developer Documentation Documentation for developers Needs Technical Feedback Needs testing from a developer perspective. labels Jun 20, 2019
Copy link
Member

@chrisvanpatten chrisvanpatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some suggestions, large and small, which attempt to break up the content and also clarify a few pieces of how server-rendered blocks work. Please let me know if you have any questions!

All suggestions have been accepted.

Co-Authored-By: Chris Van Patten <hello@chrisvanpatten.com>
@gziolo gziolo added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 22, 2019
@jodamo5
Copy link
Contributor Author

jodamo5 commented Jun 26, 2019

Hi. As a first-time contributor I'm not sure if there is anything else I'm supposed to do here. I have accepted all the comments from @chrisvanpatten and have recommitted it 6 days ago. But nothing has happened since. It says another review is required, and there are 5 pending reviewers. Can someone please review and merge these changes? Or is there something else I'm supposed to do? Thanks.

@chrisvanpatten
Copy link
Member

@jodamo5 Sorry, one more quick fix then I'm happy to approve and merge.

…creating-dynamic-blocks.md


Final suggestion accepted.

Co-Authored-By: Chris Van Patten <hello@chrisvanpatten.com>
@jodamo5
Copy link
Contributor Author

jodamo5 commented Jun 27, 2019

@chrisvanpatten One of the author tests failed in the build apparently, which seems strange. Can you provide guidance for next steps please?

@youknowriad
Copy link
Contributor

restarted the build, it should be unrelated.

@jodamo5
Copy link
Contributor Author

jodamo5 commented Jun 29, 2019

Great. All the checks passed. Can someone merge this please?

@chrisvanpatten
Copy link
Member

Thanks for your patience, @jodamo5. Looks great; excited to have this improvement in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Technical Feedback Needs testing from a developer perspective. [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants