Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native support for BlockToolbar to @wordpress/block-editor (Ported from gutenberg mobile) #16213

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Jun 18, 2019

Description

This is step 5 of wordpress-mobile/gutenberg-mobile#958
This PR ports the gutenberg-mobile BlockToolbar to gutenberg in the @wordpress/block-editor package.
This is needed to implement Inner blocks for mobile native. You can follow the progress of the port here wordpress-mobile/gutenberg-mobile#958

This PR is a simple port, it has very limited changes compared with the original BlockToolbar in gutenberg-mobile

How has this been tested?

wordpress-mobile/gutenberg-mobile#1149

Types of changes

Adds native support for a block editor component

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Tug Tug added [Status] In Progress Tracking issues with work in progress Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jun 18, 2019
@Tug Tug added this to the Future milestone Jun 18, 2019
@Tug Tug self-assigned this Jun 18, 2019
@Tug Tug removed the [Status] In Progress Tracking issues with work in progress label Jun 18, 2019
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants