Scope the data-block CSS selector. #16207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
gziolo
added
[Type] Regression
jorgefilipecosta
approved these changes
Jun 27, 2019
swissspidy
added a commit
to ampproject/amp-wp
that referenced
this pull request
Jul 2, 2019
Needed after upstream change in WordPress/gutenberg#16207.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to better scope the
[data-block]CSS selector after #15465.The new margins used in this selector rule can break other (external) components, for example
Draft.js./Cc @jasmussen @m-e-h I'd greatly appreciate your review, thanks!
Fixes #15465