Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type specifiers in validation logging #16173

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Update type specifiers in validation logging #16173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/blocks/src/api/validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ export function isEqualTagAttributePairs( actual, expected ) {
// avoids us needing to check both attributes sets, since if A has any keys
// which do not exist in B, we know the sets to be different.
if ( actual.length !== expected.length ) {
log.warning( 'Expected attributes %o, instead saw %o.', expected, actual );
log.warning( 'Expected attributes %j, instead saw %j.', expected, actual );
return false;
}

Expand Down Expand Up @@ -573,13 +573,13 @@ export function isEquivalentHTML( actual, expected ) {

// Inequal if exhausted all expected tokens
if ( ! expectedToken ) {
log.warning( 'Expected end of content, instead saw %o.', actualToken );
log.warning( 'Expected end of content, instead saw %j.', actualToken );
return false;
}

// Inequal if next non-whitespace token of each set are not same type
if ( actualToken.type !== expectedToken.type ) {
log.warning( 'Expected token of type `%s` (%o), instead saw `%s` (%o).', expectedToken.type, expectedToken, actualToken.type, actualToken );
log.warning( 'Expected token of type `%s` (%j), instead saw `%s` (%j).', expectedToken.type, expectedToken, actualToken.type, actualToken );
return false;
}

Expand All @@ -606,7 +606,7 @@ export function isEquivalentHTML( actual, expected ) {
if ( ( expectedToken = getNextNonWhitespaceToken( expectedTokens ) ) ) {
// If any non-whitespace tokens remain in expected token set, this
// indicates inequality
log.warning( 'Expected %o, instead saw end of content.', expectedToken );
log.warning( 'Expected %j, instead saw end of content.', expectedToken );
return false;
}

Expand Down