-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTML anchor explaination text #16142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally and it's working perfectly! Code looks good—let's just update it to use smart quotes and fix up that placeholder link.
{ __( 'Enter a word or two — without spaces — to make a unique web address just for this heading, called an "anchor." Then, you\'ll be able link directly to this section of your page.' ) } | ||
</p> | ||
<p className="components-base-control__learn-more"> | ||
<ExternalLink href={ __( 'https://wordpress.org/support/article/#/' ) }> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL doesn't go anywhere useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to sub it in for https://wordpress.org/support/article/page-jumps/ now that the page exists
I created new pages in HelpHub. Pleas link to this page. Embedded image will be updated after this merge. |
Smart quotes Co-Authored-By: Robert Anderson <robert@noisysocks.com>
Co-Authored-By: Robert Anderson <robert@noisysocks.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, apart from a couple of niggles I left comments about, and the link to docs still needs updating.
help={ __( 'Anchors lets you link directly to a section on a page.' ) } | ||
help={ ( | ||
<> | ||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the idea of adding extra markup in order to style the component. It's not a huge amount of work to create a stylesheet for this section (and I volunteer to do it myself if needed), is there any good reason not to though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to have a play and push to this branch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Thanks @tellthemachines! |
…rnmobile/track-unsupported-blocks * 'master' of https://github.com/WordPress/gutenberg: Bump plugin version to 6.1.0-rc.1 Update HTML anchor explaination text (#16142) Move post permalink to beneath title on mobile. (#16277) Export cloneBlock method to the mobile (#16441) Fix inconsistent references to Settings Sidebar (#16138) Adds a cache key to the blocks reducer in order to optimize the getBlock selector (#16407) Track the parent block to optimize hierarchy selectors (#16392)
Description
The HTML anchor text was unclear to anyone who didn't already know what HTML anchors are. This PR updates that text to be more user friendly, with copy written by @michelleweber.
See #15306.
Screenshots
Before:
After:
Issues
I'd like to add 1em of space between paragraphs, but there's currently no CSS file for adding new styles to this section. How should I approach this?Okay, this is fixed, but... now there are p's indented into p's.Checklist: