Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table block column alignment #16111

Merged
merged 3 commits into from
Jul 31, 2019
Merged

Add table block column alignment #16111

merged 3 commits into from
Jul 31, 2019

Commits on Jul 31, 2019

  1. Initial step at adding alignment options in table block edit component 

    Fix block.json attributes

Add cell alignment to save function

Add tests for table cell alignment

Tidy up test comments

Update JSDocs for new functions

Add unit tests

Use classnames for cell alignment

Use shorthand property

Remove alignment styles in favour of global styles

Update copy of alignment buttons

Rework cell selection border to use an actual border around a pseudoelement instead of box-shadow
    @talldan
    talldan committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    899c64c View commit details
    Browse the repository at this point in the history

  2. Make cell alignment work across columns instead of individual cells 

    Add jsdocs

Inherit the alignment property of the first cell in the column when adding new rows

Update e2e tests

Use consistent letter casing
    @talldan
    talldan committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    37a4e06 View commit details
    Browse the repository at this point in the history

  3. Address review feedback 

    Update params of getCellAttribute function

Do nothing if insertRows is unable to determine the correct cellCount for the insertion
    @talldan
    talldan committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    f00dd4e View commit details
    Browse the repository at this point in the history