Project management: Fix milestone version selection when RC is included in version

[gziolo]

Description

The current version of the plugin is 5.9-rc.1. This causes that Milestone it action creates Gutenberg 5.10 milestone where it should create Gutenberg 6.0. I fixed manually some of the latest PRs merged to be assigned to the correct milestone but we need to fix in in the actions as well.

[gziolo]

I followed: https://stackoverflow.com/a/2172367

I know little about bash :)

[noisysocks]

👍 looks good! Using [[ syntax here is okay because our shebang is #!/bin/bash and not #!/bin/sh.

[aduth]

Hmm, it's strange to me that it'd be doing this, or at least that the proposed changes would have any impact.

It should be reading from package.json and splitting on the dots, so 5.9.0-rc.1 should split to a major of 5, a minor of 9, and 0-rc.1 is effectively (or at least meant to be) thrown away.

I'm also (pleasantly?) surprised the action has been working, since previously I'd been having issues with it always being "Cancelled".

[aduth]

Or maybe it does fix the issue, but not because of the wildcard, and instead because of the difference between [ and [[, which clearly I did not understand. Or at least according to the following, the == operator is documented to not exist in "old test" [, but does exist in "new test" [[.

http://mywiki.wooledge.org/BashFAQ/031

Edit: Though, according to this one, they should be the "same" 😅

[aduth]

Okay, I get it now. The key is changing minor to $minor. Maybe my floundering is obvious to you as the author 😄 It seems it is the only necessary change, but I suppose there's no harm in the other (single to double square brackets, wildcard comparison).

[gziolo]

It should be reading from package.json and splitting on the dots, so 5.9.0-rc.1 should split to a major of 5, a minor of 9, and 0-rc.1 is effectively (or at least meant to be) thrown away.

Hmm, I no longer know if this is something that will fix the issue then. I tested it against 5.9-rc.1 and assumed that the issue comes from the fact that it reads minor as 9-rc but it looks like it should be 9 in this case:
https://github.com/WordPress/gutenberg/blob/master/package.json#L3

[aduth]

Hmm, I no longer know if this is something that will fix the issue then. I tested it against 5.9-rc.1 and assumed that the issue comes from the fact that it reads minor as 9-rc but it looks like it should be 9 in this case:
https://github.com/WordPress/gutenberg/blob/master/package.json#L3

That's not the fix, but these changes do resolve the issue. The issue comes from the fact that minor (vs. the resolved $minor variable value) will never equal 9, so it will always fall to the else case and bump the minor. This is why it created 5.10.0 instead of 6.0.0.