[Mobile] Hotfix release v1.3.1 - Fix crash on undefined image url #15618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevins
added
[Type] Bug
daniloercoli
approved these changes
May 14, 2019
There was a problem hiding this comment.
Tested by following instructions provided in wordpress-mobile/WordPress-Android#9856
LGTM!
gziolo
added
Mobile App - i.e. Android or iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This PR targets the gutenberg branch used for the
v1.3.0release of gutenberg-mobile, which is used in WordPress-Androidv12.3.1.This PR adds a check to ensure
attributes.urlexists before attempting to callindexOf. Currently, there are scenarios which can result inattributes.idbeing truthy, whileattributes.urlisnullorundefinedfor an image block.When an image is cancelled before it is finished uploading, the
urlis set tonull, but theidof the block remains. The next time the post is edited, the local draft will contain the state which triggers the crash.How has this been tested?
This was tested using the steps here: wordpress-mobile/WordPress-Android#9768 (comment)
Types of changes
This is a bug fix for the crash discovered here: wordpress-mobile/WordPress-Android#9768
Checklist: