Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the text as Gutenberg was officially released. #15394

Merged
merged 3 commits into from
Jun 22, 2019
Merged

Update the text as Gutenberg was officially released. #15394

merged 3 commits into from
Jun 22, 2019

Conversation

maximejobin
Copy link
Contributor

Description

Update the FAQ

How has this been tested?

This is not code.

Types of changes

Make the FAQ questions use the present instead of future verbe tense.

Copy link
Member

@chrisvanpatten chrisvanpatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update! Had a few small grammar nits.

docs/designers-developers/faq.md Outdated Show resolved Hide resolved
docs/designers-developers/faq.md Outdated Show resolved Hide resolved

Yes, a columns block is available in Gutenberg.

## Will there be nested blocks?
## Does Gutenberg support nested blocks?

We are currently implementing the infrastructure for nested blocks support. We expect this to open further customization opportunities. Block authors also can nest components and HTML inside of a block during construction. The UI for manipulating nested blocks is still being refined, and depending on the timing, it might not be included in the first version of Gutenberg.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This answer will probably need a rewrite; nested blocks are live and in Gutenberg.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:

Suggested change
We are currently implementing the infrastructure for nested blocks support. We expect this to open further customization opportunities. Block authors also can nest components and HTML inside of a block during construction. The UI for manipulating nested blocks is still being refined, and depending on the timing, it might not be included in the first version of Gutenberg.
Yes, it is supported. You can have multiple levels of nesting – blocks within blocks within blocks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you include it in this PR?

Co-Authored-By: maximejobin <maximejobin@users.noreply.github.com>
docs/designers-developers/faq.md Show resolved Hide resolved
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes were added to this PR. So we can merge it.

@gziolo gziolo added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 22, 2019
@gziolo gziolo merged commit af6e5ec into WordPress:master Jun 22, 2019
@gziolo
Copy link
Member

gziolo commented Jun 22, 2019

@maximejobin, congrats on your first contribution. This change should be applied a few months back 😅

@maximejobin
Copy link
Contributor Author

@gziolo Thank you for your words!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants