Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Fix change list type crash #15010

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Mobile: Fix change list type crash #15010

merged 1 commit into from
Apr 17, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Apr 17, 2019 •
edited
Loading

This PR fixes a crash when changing BlockList type:

Screen Shot 2019-04-17 at 10 22 34 AM

To test:

@etoledom etoledom added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Apr 17, 2019
@etoledom etoledom requested a review from hypest April 17, 2019 08:29
@etoledom etoledom self-assigned this Apr 17, 2019
@etoledom etoledom changed the title Rich-Text: import __unstableChangeListType as changeListType Mobile: Fix change list type crash Apr 17, 2019
@etoledom etoledom mentioned this pull request Apr 17, 2019
Merged
hypest
hypest approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etoledom etoledom merged commit a5a45ae into master Apr 17, 2019
@etoledom
Copy link
Contributor Author

Thank you!

@etoledom etoledom deleted the rnmobile/fix-changeListType-not-function branch April 17, 2019 11:01
@hypest hypest mentioned this pull request Apr 19, 2019
Merged
This was referenced Apr 29, 2019
Merged
Merged
@youknowriad youknowriad added this to the 5.6 (Gutenberg) milestone May 13, 2019
This was referenced Sep 11, 2024
Open
Open
Open
Open
Open
Open
Open
@AKJUS AKJUS mentioned this pull request Sep 12, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 12, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Open
Open
@AKJUS AKJUS mentioned this pull request Sep 14, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
@AKJUS AKJUS mentioned this pull request Sep 19, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@etoledom etoledom

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.6 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@etoledom @hypest @youknowriad