Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memize option key typo #14750

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Fix memize option key typo #14750

merged 1 commit into from
Apr 1, 2019

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Apr 1, 2019

Description

I don't know why I thought the option was size instead of maxSize... This is problematic because we're keeping rich text value cache for every change in value, which is unlikely to be ever used again.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Performance Related to performance efforts labels Apr 1, 2019
@ellatrix
Copy link
Member Author

ellatrix commented Apr 1, 2019

Saw some intermittent e2e test failures.

Summary of all failing tests
FAIL specs/block-hierarchy-navigation.test.js (9.779s)
  ● Navigating the block hierarchy › should navigate block hierarchy using only the keyboard
    expect(value).toMatchSnapshot()
    Received value does not match stored snapshot "Navigating the block hierarchy should navigate block hierarchy using only the keyboard 1".
    - Snapshot
    + Received
    @@ -9,9 +9,13 @@
      <div class="wp-block-column"></div>
      <!-- /wp:column -->
      
      <!-- wp:column -->
      <div class="wp-block-column"><!-- wp:paragraph -->
    - <p>Third column</p>
    + <p></p>
      <!-- /wp:paragraph --></div>
      <!-- /wp:column --></div>
    - <!-- /wp:columns -->"
    + <!-- /wp:columns -->
    + 
    + <!-- wp:image -->
    + <figure class="wp-block-image"><img alt=""/></figure>
    + <!-- /wp:image -->"
      80 | 		await page.keyboard.type( 'Third column' );
      81 | 
    > 82 | 		expect( await getEditedPostContent() ).toMatchSnapshot();
         | 		                                       ^
      83 | 	} );
      84 | 
      85 | 	it( 'should appear and function even without nested blocks', async () => {
      at Object.toMatchSnapshot (specs/block-hierarchy-navigation.test.js:82:42)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/block-hierarchy-navigation.test.js:9:103)
      at _next (specs/block-hierarchy-navigation.test.js:11:194)
Snapshot Summary
 › 1 snapshot failed from 1 test suite. Inspect your code changes or run `npm run test-e2e -- -u` to update them.
Test Suites: 1 failed, 34 passed, 35 total
Tests:       1 failed, 132 passed, 133 total
Snapshots:   1 failed, 62 passed, 63 total
Time:        289.871s

@ellatrix ellatrix merged commit 02d0184 into master Apr 1, 2019
@ellatrix ellatrix deleted the try/fix-memize-arg-typo branch April 1, 2019 16:00
@aduth
Copy link
Member

aduth commented Apr 1, 2019

Saw some intermittent e2e test failures.

Yeah, I got one of those as well today. I'd seen this one off-and-on for quite a long time now, but not as much recently.

@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Apr 3, 2019
ellatrix added a commit that referenced this pull request Apr 3, 2019
ellatrix added a commit that referenced this pull request Apr 4, 2019
* RichText: improve format boundary style (#14519)

* RichText: improve format boundary style

* rgb => rgba

* Paste: check plain text for gutenberg content (#14536)

* Make ClipboardButton inside a block work correctly in Safari (#7106)

* Make ClipboardButton inside a block work in Safari

* Update changelogs

* Block Editor: Update "Next" to "Unreleased" per guidelines

https://github.com/WordPress/gutenberg/blob/master/packages/README.md#maintaining-changelogs

* Input Interaction: always expand single line selection vertically (#14487)

* Input Interaction: always expand single line selection vertically

* Add e2e test

* Use MenuItem instead of IconButton (#14569)

* Remove id, infoid, label and aria-describedby from MenuItem (#14423)

* Preformatted: save line breaks as characters (#14653)

* Preformatted: save line breaks as characters

* Update e2e test

* Remove negative toolbar position rules from full-aligned blocks. (#14669)

* Fix issue with double scrollbar in Fullscreen Mode (#14677)

This PR fixes an issue where the sidebar would have two scrollbars when in fullscreen mode.

* Fix WordPress embed block resolution (#14658)

* Retry failing embeds with trailing slash (#14705)

* Fix embedding Twitter URLs with a trailing slash (Closes #12664)

* Fix race condition for WordPress URLs that end in slashes, add test

* API Fetch: Fix error on empty OPTIONS preload data (#14714)

* Input Interaction: better horizontal edge detection (#14462)

* Input Interaction: better horizontal edge detection

* Correct BR ranges

* Add e2e test

* Increase buffer for Firefox

* Clean up

* Merge isEdge logic

* Fix typo

* Address feedback

* Build docs

* Fix memize option key typo (#14750)

* RichText: unify active formats, 'selectedFormat' and 'placeholderFormat' (#14411)

* RichText: unify active formats, 'selectedFormat' and 'placeholderFormat'

* Add extra e2e test

* Only should boundary style when focused

* Update docs

* Try to trigger tests with Travis

* Restore Travis config
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
This was referenced Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended [Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants