Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText: introduce onEnterAtEnd #14143

Closed
wants to merge 1 commit into from
Closed

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Feb 27, 2019

Description

Fixes #14114. (Does not fix that issue.) Not sure if this is the right behaviour. Are there any other cases when a new paragraph should be created? What if the user presses enter in the middle? Then I think we should only insert a line break.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@folletto
Copy link
Contributor

Heya any update on this? I was about to report it and I noticed has been discussed and with the fix pending. :)

@ellatrix
Copy link
Member Author

@folletto I mislinked this PR. Do you know an existing issue that this PR would fix?

@folletto
Copy link
Contributor

So it's not a fix for #14114? I noticed that bug today in the stable WordPress release and I was about to report it, but I noticed it was marked as "closed".

@ellatrix
Copy link
Member Author

@folletto That one should be fixed by #13850.

@folletto
Copy link
Contributor

folletto commented Mar 26, 2019

Ok so should be upcoming in the next WordPress release. Got it, thanks!

@ellatrix ellatrix added the [Status] In Progress Tracking issues with work in progress label Apr 24, 2019
@gziolo
Copy link
Member

gziolo commented Aug 2, 2019

Is it similar to what I try to do in #16880? :)

@ellatrix
Copy link
Member Author

ellatrix commented Aug 2, 2019

@gziolo I think it is!

@ellatrix ellatrix closed this Jun 5, 2020
@ellatrix ellatrix deleted the try/caption-enter-behaviour branch June 5, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing Arrow Down Button On Keyboard Make Caption Field Longer On Image Block
3 participants