Use codetabs to label ESNext code as such #13781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
noisysocks,
talldan and
youknowriad
as code owners
gziolo
approved these changes
Feb 10, 2019
|
I was thinking a bit more about https://www.npmjs.com/package/@wordpress/plugins
https://github.com/WordPress/gutenberg/blob/master/packages/plugins/README.md
Given that it is possible to use HTML tags and therefore comments, maybe we could come up with a syntax that would display properly everywhere? It might be challenging but it's worth exploring in my opinion. I know that @griffbrad was interesting in improving how we handle code snippets in our docs. |
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This was referenced Apr 30, 2020
This was referenced May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tests using the {% codetabs %} markup to label an ESNext block of code as such, even without the alternative ES5 tab included.
There can be confusion on what type of code is being displayed/copied/pasted, so being able to label ESNext code as such will help people working in an ES5 only environment that there might be a potential for problems if they copy/paste the code as shown.
Types of changes
Documentation.