Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText Readme - Adding missing props to save function inside ES5 Example #13752

Merged
merged 2 commits into from
Feb 8, 2019
Merged

RichText Readme - Adding missing props to save function inside ES5 Example #13752

merged 2 commits into from
Feb 8, 2019

Conversation

fabiankaegy
Copy link
Member

Description

I've added missing props to the save function inside the readme es5 example of the RichText component.

How has this been tested?

Change only affect the documentation

Types of changes

Change only affect the documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

In the ES5 example for the RichText component the props are not passed into the save function. Inside the save function they are called though.
merge master back into fork
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for sending this pull request 👍

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Feb 8, 2019
@gziolo gziolo merged commit be36d1a into WordPress:master Feb 8, 2019
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
In the ES5 example for the RichText component the props are not passed into the save function. Inside the save function they are called though.
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
In the ES5 example for the RichText component the props are not passed into the save function. Inside the save function they are called though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants