Rename default block styles to "Default"

[kjellr]

Resolves #13660.

This aligns name we're using in the UI with the classname, and also lets us be a little less prescriptive about what exactly the default block styles per theme should look like.

• Separator block: Short Line ➡️ Default
• Blockquote block: Regular ➡️ Default
• Pullquote block: Regular ➡️ Default
• Table block: Regular ➡️ Default
• Button block: Rounded ➡️ Default

[jasmussen]

Love it, thank you! 🤟 from me, I guess it just needs a code sanity check. Pretty sure this doesn't require deprecation handlers.

[youknowriad]

I think we landed a PR recently where we could drop these entirely from here and they will be added automatically (needs verification)

[mapk]

Can we get a reference to that PR here? What exactly can we drop?

[youknowriad]

Sure sorry it wasn't that clear.

Here's the PR #12519

I think the entire line can be dropped (the default style)

[kjellr]

I just tested this, and it almost works. The block has the correct styles by default, but the "Default" style option does not appear in the style picker:

Since it's not there, if you select an alternate style, there'd be no way to switch back to the default. 😕

So for now at least, I think we do need these lines.

[youknowriad]

Mmm weird, I though it was the intent of the linked PR. pinging @swissspidy to check my assumptions :) but feel free to move forward with the PR.

[swissspidy]

Yeah that was the goal of #12519 🤔 No idea why it doesn't work, I would have to investigate.

[ZebulanStanphill]

Since the "Rounded" style for buttons is now just "Default", wouldn't it make sense to also add a dedicated "Rounded" style that themes can choose to support if their default isn't rounded? Same for other blocks where the default style wasn't previously just called "Regular".

[youknowriad]

@ZebulanStanphill nothing stops themes from registering custom style variations.

[ZebulanStanphill]

@youknowriad I know, but I thought it was kind of weird to provide a core style for a long line separator but not a dedicated core style for a short line separator.

[mapk]

Just tested and everything appears to be working great! I've a few notes.

1. The is-style-default class didn't appear when I added the block. It only appeared when I selected it from the block style variations. Maybe this is how it always worked?
2. The Table block show default in the Block Styles, but uses the class is-style-regular in the HTML. Is this right?

[kjellr]

1. The is-style-default class didn't appear when I added the block. It only appeared when I selected it from the block style variations. Maybe this is how it always worked?

Yeah, that's how it behaves today.

2. The Table block show default in the Block Styles, but uses the class is-style-regular in the HTML. Is this right?

Hmm... you're right. That's not ideal. Ideally we should be using is-style-default there. But changing that up will be a breaking change for some themes, so I'm not sure the best way to handle that. My inclination is to leave it as is, but I could use another viewpoint on that.

[mapk]

Thanks for addressing those points, @kjellr.
I don't think number 2 should hold this PR up. LGTM

[mapk]

Alrighty,

[kjellr]

Thanks, everyone!

[webmandesign]

Hi guys,

I'm really too late to the party here, sorry, but still I can see an issue with Separator block styles (and probably other blocks too):

styles: [
	{ name: 'default', label: __( 'Default' ), isDefault: true },
	{ name: 'wide', label: __( 'Wide Line' ) },
	{ name: 'dots', label: __( 'Dots' ) },
],

If a theme styles <hr> wide by default (which I'm sure many themes do), than a user is offered 2 same options here: "Defalut" and "Wide line".

Wouldn't this cause UX issues?
How could a theme user select a "Short line" style then?
Or "Short line" style is not available any more now?

[swissspidy]

@webmandesign See #14102.

[webmandesign]

Thanks @swissspidy