Decode permalinks with URL encoding

[Naerriel]

Description

Fixes #13229.
Currently slug for the permalink is encoded and that PR simply decodes it.

How has this been tested?

Ran npm run test and looked on the permalinks that were previously encoded and saw that they were decoded.

Screenshots

Types of changes

Bug fix.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

Questions:

I've had doubts where in the code this decoding should be done and I've chose the view, as it probably isn't needed elsewhere. Please let me know, what you think.

[gziolo]

I think @earnjam or @jorgefilipecosta should be the best suited to help to validate the changes proposed.

[jorgefilipecosta]

Hi @Naerriel,
Thank you for this improvement.
I noticed there is another place we need to fix. If we go to title the permalink editor appears above it. If we press edit we see the field with the encoded representation. Probably we should add another decodeURIComponent call.

[Naerriel]

Hi @jorgefilipecosta
I have made another decodeURIComponent call in permalink editor, as you have suggested it. During that fix I have also found that post-publish-panel/panel.js also requires decoding. Maybe we could just decode it straight in the store?

If I'm correct, I could just decode it in reducer to action REQUEST_POST_UPDATE_SUCCES. What do you think?

[Naerriel]

Hey @earnjam,
Are those changes satisfactory?

[earnjam]

Sorry for the delay @Naerriel. Just did some testing and this PR looks good to me!

[rachidev84]

there's another issue when you switching wordpress to arabic language :
about RTL :
the permalink display in RTL not in LTR, it must be in LTR because that how it show on all browser.
this is how it look like on wordpress in edit post :
https://prnt.sc/o76dkn

and this is how must be : https://www.byarabic.com/مقالة-الموقع/
Another issue is if someone copy my post link from website and past it in other place via facebook messenger or any browser it show them url with %%%% like this :
https://www.byarabic.com/%d9%85%d9%82%d8%a7%d9%84%d8%a9-%d8%a7%d9%84%d9%85%d9%88%d9%82%d8%b9/

[aduth]

@rachidev84 Can you please create a new issue so that this is properly tracked, since this pull request is already merged and will not likely receive much future attention from collaborators?

https://github.com/WordPress/gutenberg/issues/new/choose