Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Adds undo/redo support for the title. #13514

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Mobile: Adds undo/redo support for the title. #13514

merged 2 commits into from
Jan 28, 2019

Conversation

diegoreymendez
Copy link
Contributor

Description

Adds undo / redo support for native.

How has this been tested?

This should be tested through the following PR: wordpress-mobile/gutenberg-mobile#501

Types of changes

Simply adds back some code from post-title/index.js into post-title/index.native.js.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@diegoreymendez diegoreymendez added [Type] Enhancement A suggestion for improvement. Mobile Web Viewport sizes for mobile and tablet devices Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Feature] History History, undo, redo, revisions, autosave. labels Jan 25, 2019
@diegoreymendez diegoreymendez self-assigned this Jan 25, 2019
@diegoreymendez diegoreymendez changed the title Adds undo/redo support for the title. Mobile: Adds undo/redo support for the title. Jan 25, 2019
@diegoreymendez diegoreymendez mentioned this pull request Jan 28, 2019
Merged
daniloercoli
daniloercoli reviewed Jan 28, 2019
View reviewed changes
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@diegoreymendez diegoreymendez merged commit b598fb3 into master Jan 28, 2019
@diegoreymendez diegoreymendez deleted the rnmobile/372-writing-flow-add-back-undo-redo-support-2 branch January 28, 2019 17:07
This was referenced Feb 4, 2019
Merged
Closed
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@diegoreymendez @youknowriad
Adds undo/redo support for the title. (#13514)
5ce27ce
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@diegoreymendez @youknowriad
Adds undo/redo support for the title. (#13514)
219b513
@gziolo gziolo removed the Mobile Web Viewport sizes for mobile and tablet devices label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloercoli daniloercoli daniloercoli approved these changes

Assignees

@diegoreymendez diegoreymendez

Labels
[Feature] History History, undo, redo, revisions, autosave. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegoreymendez @daniloercoli @gziolo