Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces PluginSettingsSidebar slotfill to the Document sidebar. #13361
Introduces PluginSettingsSidebar slotfill to the Document sidebar. #13361
Changes from all commits
10f2155
1e71527
1f84880
1b8abb5
4e157e3
c16ceec
ffe0dc7
352783b
ed2fe85
dbdb17b
80d16f9
44df501
60ecdbf
becc99e
baabb3d
80da436
0c10e9e
7875f9c
4c0c834
42c74b7
739c0ad
4c4641a
b41b60a
7f84a0e
47b6603
86b9774
5fde5a1
d406e81
3dd3031
ae92d91
88e5faf
642b80f
25a396e
356397f
fd8f007
28984f1
11e6281
ac92347
c15441e
c56219f
628436b
7d83a36
26bca28
cca3571
8b98804
2bc05de
6b57e00
797ced8
30e4692
b6f8ab6
f4f25ef
b1954c5
c78138a
1b5c6f2
3ccdbfc
f71ae7d
b1e1f7f
1744eec
9e36834
2a7f05c
7c8a6ab
ddb5028
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also include
icon
which is now supported with the default coming from the plugin's definition. This is how it's documented for thePluginSidebar
:gutenberg/packages/edit-post/src/components/sidebar/plugin-sidebar/index.js
Line 85 in 1d653d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aduth any thougs on the naming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me as proposed.