Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing a context variable to the custom format prepareEditTreeValue #11630

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Support passing a context variable to the custom format prepareEditTreeValue #11630

merged 1 commit into from
Nov 9, 2018

Conversation

youknowriad
Copy link
Contributor

This PR adds an identifier prop to the RichText component.
It also passes the "clientId" and "richTextIdentifier" as "context" to the format API.

@youknowriad youknowriad added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Nov 8, 2018
@youknowriad youknowriad added this to the 4.3 milestone Nov 8, 2018
@youknowriad youknowriad self-assigned this Nov 8, 2018
@youknowriad youknowriad requested review from ellatrix and a team November 8, 2018 15:30
tofumatt
tofumatt approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me; seems like it'd be a good fit for some unit tests, but I know timelines are tight and it's experimental 🤷‍♂️

@gziolo
Copy link
Member

gziolo commented Nov 8, 2018

Any plans to add identifier to other blocks?

@youknowriad
Copy link
Contributor Author

@gziolo Could be done as needed. This is just a first iteration to implement the concept.

@youknowriad youknowriad merged commit 89539fd into try/prepare-editable Nov 9, 2018
@youknowriad youknowriad deleted the add/context-support branch November 9, 2018 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofumatt tofumatt tofumatt approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@youknowriad youknowriad

Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowriad @gziolo @tofumatt