Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert refactoring hierarchical term selector using the data module #11395

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

youknowriad
Copy link
Contributor

closes #11335 and #11279

Reverts partially #10089

Unfortunately, we can't use the data module for taxonomies at the moment because the contributor's role can't access the edit context.

Testing instructions

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Nov 2, 2018
@youknowriad youknowriad added this to the 4.2 milestone Nov 2, 2018
@youknowriad youknowriad self-assigned this Nov 2, 2018
@notnownikki
Copy link
Member

The new test in #11359 catches this. Adding myself to the conversation here so I can keep track of when this is resolved :)

Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've manually tested as an author and verified that categories can be managed.

@youknowriad youknowriad merged commit 3caec34 into master Nov 2, 2018
@youknowriad youknowriad deleted the revert/hierarchical-term-selector branch November 2, 2018 12:49
@slimmilkduds
Copy link

I just installed the nightly build from https://builds.danielbachhuber.com/gutenberg-nightly.zip and I still can't see taxonomies terms for non-administrators (I only use custom wp-roles). What specific capability is needed for this to work?

@slimmilkduds
Copy link

Never mind, I found that 4.1 rc 2 has been released and that works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taxonomy terms are gone in 4.2 rc-1
4 participants