Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: Runs all parser implementations against the same tests #11320

Merged
merged 9 commits into from
Oct 31, 2018
Merged

Parser: Runs all parser implementations against the same tests #11320

merged 9 commits into from
Oct 31, 2018

Commits on Oct 31, 2018

  1. Parser: Runs all parser implementations against the same tests 

    So far we haven't added too many tests to the parsers but the ones we
_have_ added are in separate places and each implementation runs against
a different set of tests.

In this patch we're creating `shared-tests.js` in the spec parser that
defines a suite of conformance tests for the parser and then we're using
that base test-builder to dynamically create test suites for each
implementation such that they all run the same suite.

It's probably easier to understand by reading the code than this
summary.

Of note: by calling to `php` directly we're able to run the PHP parsers
against the same tests as we are the JavaScript implementations. We
should be able to do this for any implementation as long as the required
binaries are available in the CI environment (Rust, for example).
    @dmsnell
    dmsnell committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    f46735a View commit details
    Browse the repository at this point in the history

  2. update snapshot

    @dmsnell
    dmsnell committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    922867d View commit details
    Browse the repository at this point in the history

  3. add explicit timeouts to spanSync call

    @dmsnell
    dmsnell committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    42adae3 View commit details
    Browse the repository at this point in the history

  4. skip tests if php is unavailable

    @dmsnell
    dmsnell committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    d066372 View commit details
    Browse the repository at this point in the history

  5. skip tests if php is unavailable

    @dmsnell
    dmsnell committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    becc7dd View commit details
    Browse the repository at this point in the history

  6. unshadow document

    @dmsnell
    dmsnell committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    2c1d61d View commit details
    Browse the repository at this point in the history

  7. use package for test runner import

    @dmsnell
    dmsnell committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    1a09538 View commit details
    Browse the repository at this point in the history

  8. conditionally compile test code?

    @dmsnell
    dmsnell committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    0203593 View commit details
    Browse the repository at this point in the history

  9. use file path for npm dependency

    @dmsnell
    dmsnell committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    f5f501b View commit details
    Browse the repository at this point in the history