Reusable blocks: Mark API as experimental #11230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
the
[Feature] Synced Patterns
noisysocks
force-pushed
the
update/mark-reusable-block-api-as-experimental
branch
from
c9ac799
to
9b8ccac
Compare
youknowriad
approved these changes
Oct 30, 2018
|
I will add it. |
The reusable block selectors and actions will need to change in the future. Give ourselves some breathing room to make these changes after Gutenberg 4.2 by marking them as experimental.
gziolo
force-pushed
the
update/mark-reusable-block-api-as-experimental
branch
from
9b8ccac
to
175d3cc
Compare
gziolo
force-pushed
the
update/mark-reusable-block-api-as-experimental
branch
from
175d3cc
to
7975381
Compare
|
Addressed with 7975381. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reusable block selectors and actions will need to change in the future when we finish the work in #7453.
This PR gives us some breathing room to make these changes after the API lockdown in 4.2 by marking all reusable block selectors and actions as
__experimental.Deprecated selectors:
getReusableBlock,getReusableBlocks– Best to usegetEntityRecordinsteadisFetchingReusableBlock– Best to useisResolvinginsteadisSavingReusableBlock– We'll likely add an equivalent core data selector for thisDeprecated actions:
fetchReusableBlocks,receiveReusableBlocks– Best to usegetEntityRecordsinsteadsaveReusableBlock,updateReusableBlockTitle– Best to usesaveEntityRecordinsteadconvertBlockToStatic,convertBlockToRegular– Not likely to go away, but better safe than sorryUntouched:
wp.blocks.isReusableBlock– This helper won't need to change.getInserterItems– In the future we'll have to have this selector select fromgetEntityRecords(). Not sure if we should deprecate it to be safe...To test: