Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block descriptions #11148

Closed
wants to merge 1 commit into from
Closed

Update block descriptions #11148

wants to merge 1 commit into from

Conversation

Soean
Copy link
Member

@Soean Soean commented Oct 27, 2018

Description

This PR updates the block descriptions.
Fixes #10919

@Soean Soean added [Feature] Blocks Overall functionality of blocks [Type] Copy Issues or PRs that need copy editing assistance labels Oct 27, 2018
@youknowriad youknowriad added this to the 4.2 milestone Oct 27, 2018
@@ -36,9 +36,13 @@ export const name = 'core/quote';

export const settings = {
title: __( 'Quote' ),
description: __( 'Maybe someone else said it better -- add some quoted text.' ),

description: __( 'Give quoted text visual emphasis. "In quoting others, we cite ourselves." — Julio Cortázar' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other user-facing strings use fancy quotes instead of typewriter quotes, e.g. the NUX tips.

@@ -76,7 +76,7 @@ export const name = 'core/paragraph';
export const settings = {
title: __( 'Paragraph' ),

description: __( 'Add some basic text.' ),
description: __( 'Start with the building block of all narrative.' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "narratives", rather than "narrative"?

@@ -26,6 +26,8 @@ export const name = 'core/media-text';
export const settings = {
title: __( 'Media & Text' ),

description: __( 'Set media and words side-by-side media for a richer layout.' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a stray "media" word here.

@@ -102,7 +102,7 @@ const schema = {
export const settings = {
title: __( 'Image' ),

description: __( 'They’re worth 1,000 words! Insert a single image.' ),
description: __( 'Insert an image to make a visual statement.' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be changed to be closer to the Video block description.

@@ -15,10 +15,14 @@ export const name = 'core/embed';

export const settings = getEmbedBlockSettings( {
title: _x( 'Embed', 'block title' ),
description: __( 'The Embed block allows you to easily add videos, images, tweets, audio, and other content to your post or page.' ),

description: __( 'Embed videos, images, tweets, audio, and other content from external sources.' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should say "posts" rather than "tweets" to be more general and not reference any specific platform or service.

@@ -17,7 +17,7 @@ export const name = 'core/audio';
export const settings = {
title: __( 'Audio' ),

description: __( 'Embed an audio file and a simple audio player.' ),
description: __( 'Embed a simple audio player.' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be changed to be similar to the Video block description.

@karmatosed
Copy link
Member

Noting we have an issue in #10971 also for reference. Ideally we iterate in first PR.

@Soean Soean closed this Oct 28, 2018
@youknowriad youknowriad deleted the update/block-descriptions branch October 28, 2018 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants